Fix issue cloning objects when sending client payloads - attempt 2 #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
commented
Aug 26, 2024
| @@ -50,7 +50,9 @@ type Hook = { | |||
| const DEVTOOLS_KEY = Symbol.for("apollo.devtools"); | |||
|
|
|||
| const tab = createWindowActor(window); | |||
| const messageAdapter = createWindowMessageAdapter(window); | |||
| const messageAdapter = createWindowMessageAdapter(window, { | |||
| jsonSerialize: true, | |||
There was a problem hiding this comment.
We only need to do this for the data sent from the client into the extension since we control the payloads from the extension to this script and can better guarantee we're always sending serializable values.
#815 Bundle Size — 1.51MiB (+0.01%).5bdbf5c(current) vs aca71ee main#814(baseline) Warning Bundle contains 13 duplicate packages – View duplicate packages Bundle metrics
|
| Current #815 |
Baseline #814 |
|
|---|---|---|
 Initial JS |
1.47MiB(+0.01%) |
1.47MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
95.38% |
0% |
| Chunks |
5 |
5 |
| Assets |
12 |
12 |
| Modules |
1218 |
1218 |
| Duplicate Modules |
45 |
45 |
| Duplicate Code |
3.12%(+1.96%) |
3.06% |
| Packages |
183 |
183 |
| Duplicate Packages |
10 |
10 |
Bundle size by type 1 change 1 regression
| Current #815 |
Baseline #814 |
|
|---|---|---|
| JS |
1.47MiB (+0.01%) |
1.47MiB |
| IMG |
35.85KiB |
35.85KiB |
| HTML |
810B |
810B |
| Other |
778B |
778B |
Bundle analysis report Branch jerel/fix-json-serialize Project dashboard
Generated by RelativeCI Documentation Report issue
phryneas
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1479
Attempt 2 at fixing the issue of sending data from the client into devtools. This solution opts to
JSON.parse(JSON.stringify(...))every message sent from the injected script so that we don't forget to do this for additional payloads in the future.