Merge pull request #393 from dahjelle/removeRefsFromStore

WIP: Fix map function returning undefined.
apollographql · Jul 13, 2016 · 16a49d9 · 16a49d9
2 parents 17e4bfb + 4371e7f
commit 16a49d9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ Expect active development and potentially significant breaking changes in the `0
 
 ### vNEXT
 
+- Fix map function returning `undefined` in `removeRefsFromStoreObj`. [PR #393](https://github.com/apollostack/apollo-client/pull/393)
+
 ### v0.4.1
 
 - Allow `client.mutate` to accept an `optimisticResponse` argument to update the cache immediately, then after the server responds replace the `optimisticResponse` with the real response. [Issue #287](https://github.com/apollostack/apollo-client/issues/287) [PR #336](https://github.com/apollostack/apollo-client/pull/336)

diff --git a/src/data/mutationResults.ts b/src/data/mutationResults.ts
@@ -183,10 +183,10 @@ function removeRefsFromStoreObj(storeObj, dataId) {
         affected = true;
         return filteredArray;
       }
-
-      // If not modified, return the original value
-      return value;
     }
+
+    // If not modified, return the original value
+    return value;
   });
 
   if (affected) {

diff --git a/test/mutationResults.ts b/test/mutationResults.ts
@@ -446,6 +446,8 @@ describe('mutation results', () => {
 
         // The item shouldn't be in the store anymore
         assert.notProperty(client.queryManager.getApolloState().data, 'Todo3');
+        // shouldn't have affected other data elements
+        assert.notEqual(client.queryManager.getApolloState().data['TodoList5']['__typename'], undefined);
       });
     });
   });