Skip to content

Commit

Permalink
Merge pull request #3701 from combizs/fragment-matcher-error-typo
Browse files Browse the repository at this point in the history
Fixed fragment matcher error message [#3701]
  • Loading branch information
hwillson authored Aug 9, 2018
2 parents 6e2565c + 19ae310 commit d3c8d00
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
**Note:** This is a cumulative changelog that outlines all of the Apollo Client project child package changes that were bundled into a specific `apollo-client` release.

## vNext

### Apollo Cache In-Memory (vNext)

- Fix typo in `console.warn` regarding fragment matching error message. <br/>
[@combizs](https://github.com/combizs) in [#3701](https://github.com/apollographql/apollo-client/pull/3701)


## 2.3.8 (August 9, 2018)

### Apollo Client (2.3.8)
Expand Down
9 changes: 5 additions & 4 deletions packages/apollo-cache-inmemory/src/fragmentMatcher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,11 @@ export class HeuristicFragmentMatcher implements FragmentMatcherInterface {
// If it's 1, we don't want to return anything, if it's 2 we want to match. We can't tell the
// difference, so we warn the user, but still try to match it (backcompat).
warnOnceInDevelopment(
`You are using the simple (heuristic) fragment matcher, but your queries contain union or interface types.
Apollo Client will not be able to able to accurately map fragments.` +
`To make this error go away, use the IntrospectionFragmentMatcher as described in the docs: ` +
`https://www.apollographql.com/docs/react/recipes/fragment-matching.html`,
'You are using the simple (heuristic) fragment matcher, but your ' +
'queries contain union or interface types. Apollo Client will not be ' +
'able to accurately map fragments. To make this error go away, use ' +
'the `IntrospectionFragmentMatcher` as described in the docs: ' +
'https://www.apollographql.com/docs/react/recipes/fragment-matching.html',
'error',
);

Expand Down

0 comments on commit d3c8d00

Please sign in to comment.