remove optimisticResponse property on mutation actions

apollographql · Jul 12, 2016 · ea1b746 · ea1b746
1 parent c16e400
commit ea1b746
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/src/QueryManager.ts b/src/QueryManager.ts
@@ -274,7 +274,6 @@ export class QueryManager {
           result,
           mutationId,
           resultBehaviors,
-          optimisticResponse,
         });
 
         return result;
@@ -285,7 +284,6 @@ export class QueryManager {
           error: err,
           mutationId,
           resultBehaviors,
-          optimisticResponse,
         });
 
         return Promise.reject(err);

diff --git a/src/actions.ts b/src/actions.ts
@@ -91,7 +91,6 @@ export interface MutationResultAction {
   type: 'APOLLO_MUTATION_RESULT';
   result: GraphQLResult;
   mutationId: string;
-  optimisticResponse: Object;
   resultBehaviors?: MutationBehavior[];
 }
 

diff --git a/src/optimistic-data/store.ts b/src/optimistic-data/store.ts
@@ -37,7 +37,6 @@ export function optimistic(
       type: 'APOLLO_MUTATION_RESULT',
       result: { data: action.optimisticResponse },
       mutationId: action.mutationId,
-      optimisticResponse: null,
       resultBehaviors: action.resultBehaviors,
     } as ApolloAction;
 
@@ -64,7 +63,7 @@ export function optimistic(
 
     return newState;
   } else if ((isMutationErrorAction(action) || isMutationResultAction(action))
-               && action.optimisticResponse) {
+               && previousState.some(change => change.mutationId === action.mutationId)) {
     // throw away optimistic changes of that particular mutation
     const newState = previousState.filter(
       (change) => change.mutationId !== action.mutationId);