Query strange behavior - unlimited loading state after success mutation with react-apollo

[ARMGAMES]

Created issue at react-apollo, but there guys suggested that this apollo bug. This is issue link -apollographql/react-apollo#368

[helfer]

@SachaG mentioned in the other issue that he has tracked this down to partial data being provided to the reducer. I think we currently throw an error if there's partial data outside a fragment, but we don't do so when partial data is inside a fragment due to how we detect fragments.

I think a refactor will be needed to make sure that we can catch missing data in fragments as well.

[donedgardo]

I thought #980 fixed this. I'm having trouble with this too.
In my case my render method has a if statement that renders if the this.props.data.loading is false otherwise loads a spinner.
I console.log the data and it logs correctly:

{"variables":{},"loading":false,"networkStatus":7,"foodtrucks":[{"name":"FoodTruck #1","__typename":"FoodTruck"},{"name":"FoodTruck #2","__typename":"FoodTruck"}]}

but my app crashes with an odd error.

Error in observer.next 

[helfer]

@donedgardo #980 was a fix for a different issue. I'm not sure your error is related since it indicates loading: false. It's a bit hard to tell what your error is, because it doesn't include a stack trace. Did you forget to paste it, or is there just no stack trace?

[donedgardo]

My issue was isolated, i got it fixed, sorry and thanks.

…

On Wednesday, December 21, 2016, Jonas Helfer ***@***.***> wrote: @donedgardo <https://github.com/donedgardo> #980 <#980> was a fix for a different issue. I'm not sure your error is related since it indicates loading: false. It's a bit hard to tell what your error is, because it doesn't include a stack trace. Did you forget to paste it, or is there just no stack trace? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1039 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACXlUJybLtm4ppSdwAdtd87bJRraRKCUks5rKK78gaJpZM4LMjI-> .

[scf4]

Ran into a similar (or same) bug recently and was planning to open an issue.

If I use $unshift it works fine (prepends item to list) but $push (to append) has me stuck in loading state.

[scf4]

Okay yes I believe my issue is related to the partial result bug.

I have this query:

thread: {
  posts: {
    edges: {
      node: {
        id
        content
      }
    }
  }
}

and the mutation only returns { id, content } of course.

So mutations can't work with Apollo if we want to use edges?

[helfer]

@scf I'm sorry, I can't really tell what your issue/question is. From experience, it seems that unlimited loading state is often the result of a updateQuery function not returning all data.

If it's indeed the case that the only difference is $unshift vs. $push, then it would be great if you could make a PR with a failing test. Just find the current test most relevant to your issue, copy, rename and adapt it to fail when using $push, but pass when using $unshift.

[helfer]

Is anyone still encountering this issue? If yes, please let me know and I'll reopen the issue.

[c10b10]

Checked Network tab, and response from the server is correct, but networkStatus stuck at 2, and loading stuck to true.

This happens the third time I load a component that gets a query.