Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies #1074

Closed
kamilkisiela opened this issue Dec 21, 2016 · 3 comments
Closed

Circular dependencies #1074

kamilkisiela opened this issue Dec 21, 2016 · 3 comments

Comments

@kamilkisiela
Copy link
Contributor

kamilkisiela commented Dec 21, 2016

store.js -> optimistic-data/store.js -> store.js
core/ObservableQuery.js -> core/QueryManager.js -> scheduler/scheduler.js -> core/ObservableQuery.js
core/QueryManager.js -> scheduler/scheduler.js -> core/QueryManager.js
optimistic-data/store.js -> store.js -> optimistic-data/store.js
scheduler/scheduler.js -> core/QueryManager.js -> scheduler/scheduler.js

@DxCx

@helfer
Copy link
Contributor

helfer commented Dec 21, 2016

@kamilkisiela what is this for? Some tool that cannot handle circular dependencies?

PS: I'm surprised there isn't one between ApolloClient.ts and QueryManager.ts.

@kamilkisiela
Copy link
Contributor Author

@helfer yes, rollup + systemjs for an example. There's a webpack plugin that shows all circular dependencies.

We work on some cool thing and this stops us, last missing piece.

Urigo added a commit that referenced this issue Dec 22, 2016
Note: Typescript files with only types, are used only in compilation
phase and not going to be imported on compiled javascript.

Closes #1074
@carloscordon
Copy link

I also managed to hit this issue with rollup. It took quite a while to debug. FWIW, here's the rollup issue for tracking this: rollup/rollup-plugin-commonjs#105

kamilkisiela pushed a commit that referenced this issue Jan 4, 2017
Note: Typescript files with only types, are used only in compilation
phase and not going to be imported on compiled javascript.

Closes #1074
@helfer helfer closed this as completed in a781301 Jan 9, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants