Canonization Options Not Passed via Diff

[aj-foster]

Intended outcome:

Use the canonizeResults option to manually disable (or, after #8822, manually enable) canonization with the InMemoryCache.

Actual outcome:

While the customized value of canonizeResults is used in most situations, there are edge cases in which the default value of canonizeResults is used instead.

How to reproduce the issue:

Using the following configuration:

new ApolloClient({
    defaultOptions: { watchQuery: { canonizeResults: false } , query: { canonizeResults: false } },
    // ...
  });

If you perform a query that involves InMemoryCache — and specifically, its private broadcastWatch function — then custom values of canonizeResults are not properly passed down.

This is the offending call. The call to diff should pass along c.canonizeResults. This is closely related to work @benjamn is currently doing.

Versions

  System:
    OS: macOS 11.6
  Binaries:
    Node: 12.16.1 - ~/.asdf/installs/nodejs/12.16.1/bin/node
    Yarn: 3.0.2 - ~/Documents/Projects/ps-dev/labs/node_modules/.bin/yarn
    npm: 7.8.0 - ~/.asdf/installs/nodejs/12.16.1/.npm/bin/npm
  Browsers:
    Chrome: 93.0.4577.82
    Safari: 15.0
  npmPackages:
    @apollo/client: ^3.3.21 => 3.4.13 
    react-apollo: ^3.1.5 => 3.1.5