Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write subscription results under ROOT_SUBSCRIPTION ID instead of ROOT_QUERY #999

Closed
stubailo opened this issue Dec 6, 2016 · 2 comments
Closed
Assignees

Comments

@stubailo
Copy link
Contributor

stubailo commented Dec 6, 2016

This will help show in the Apollo dev tools whether data came from a subscription or query.

@dko-slapdash
Copy link

Could you please clarify, is it true (and on intent) that ROOT_SUBSCRIPTION is never read anywhere in the code, it's only written?

The following search shows that there are no more references to ROOT_SUBSCRIPTION (including dev tools): https://github.com/search?q=org%3Aapollographql+ROOT_SUBSCRIPTION&unscoped_q=ROOT_SUBSCRIPTION

@jedwards1211
Copy link
Contributor

Not only that, subscription data shouldn't overwrite cached query data automatically anyway, right?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants