[Data masking] Allow null as a valid from value
#12131
Open
+137
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 94e0f01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Docs Preview ReadyNo new or changed pages found. |
commit: |
|
Here is the updated component with this change: apollographql/spotify-showcase@c630fa9 Much cleaner and required much less updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out data masking with the Spotify showcase, I discovered some cases where it was a bit difficult to adopt data masking without some significant refactors. For example, see apollographql/spotify-showcase@a24c3ed. In this component, I had to split out a fallback component and a component that renders the non-null case simply because we can't conditionally render hooks and
nullis not a validfromvalue inuseFragment. By adding support fornull, it should make data masking a bit easier to adopt by avoiding these types of refactors where a fallback state is perfectly valid.