Rethrow caught errors in setTimeout #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebmer
reviewed
Mar 6, 2017
| @@ -368,10 +368,12 @@ export class QueryManager { | |||
| try { | |||
| observer.error(apolloError); | |||
| } catch (e) { | |||
| console.error('Error in observer.error \n', e.stack); | |||
| // Throw error outside this control flow to avoid breaking Apollo's state | |||
| setTimeout(() => { throw e; }, 0); | |||
|
Thanks a lot @dallonf ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate approach to #1348 for fixing #1141. This approach is a bit more of a head-scratcher when you run into the code, but it doesn't break as many tests.