Remove rxjs-compat use
#3526
Merged
Remove rxjs-compat use
#3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While merging in #3500 we encountered `rxjs` `from` issues in some of the tests. I added `rxjs-compat` to work around these issues, but this shouldn't be needed. This commit aims to revert the `rxjs-compat` changes, to see if the CI gods will now be appeased.
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While merging in #3500 we encountered
rxjsfromissues in some of the tests. I addedrxjs-compatto work around these issues, but this shouldn't be needed. This commit aims to revert therxjs-compatchanges, to see if the CI gods will now be appeased.