Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use or condition instead of ternary conditional #3574

Merged
merged 3 commits into from
Jun 20, 2018
Merged

use or condition instead of ternary conditional #3574

merged 3 commits into from
Jun 20, 2018

Conversation

chentsulin
Copy link
Contributor

should be more readable

@apollo-cla
Copy link

apollo-cla commented Jun 13, 2018 •
edited
Loading

Fails
🚫

No CHANGELOG added.
Warnings
⚠️

There are library changes, but not tests. That's OK as long as you're refactoring existing code

Generated by 🚫 dangerJS

hwillson
hwillson approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more readable @chentsulin - thanks very much!

@hwillson hwillson merged commit 8b97321 into apollographql:master Jun 20, 2018
@dependencies dependencies bot mentioned this pull request Jun 20, 2018
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chentsulin @apollo-cla @hwillson