Move methods to observable (Issue #194) #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
|
| @@ -3,6 +3,7 @@ | |||
| Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 3 to 6 months), to signal the start of a more stable API. | |||
|
|
|||
| ### vNEXT | |||
| - moved refetch(), startPolling(), and stopPolling() methods from QuerySubscription to ObservableQuery [Issue #194] [PR #362] | |||
There was a problem hiding this comment.
Can we add the links to the issue/PR? It's a bit verbose but it's really helpful to be able to click on them.
|
Looks great so far, just a few comments. The current implementation works well but I think we should reorganize a few things before merging. |
|
Since this is also a breaking change, maybe we should release with the error handling change? |
|
Agreed! |
stubailo
force-pushed
the
move-methods-to-observable
branch
from
fd1750f
to
2685c38
Compare
stubailo
force-pushed
the
move-methods-to-observable
branch
from
2685c38
to
5fc2545
Compare
kamilkisiela
added a commit
to kamilkisiela/apollo-angular
that referenced
this pull request
Jul 16, 2016
Methods moved to an observable apollographql/apollo-client#362
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: