Stop deep freezing query results #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apollo Client is currently deep freezing query results, making query results immutable. This restriction was originally put in place to reserve the possibility of potentially returning direct cache references in query results. Since doing this isn't currently planned, and there have been many requests to make query results mutable, this commit disables query result deep freezing. Fixes #1909.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo Client is currently deep freezing query results, making query results immutable. This restriction was originally put in place to reserve the possibility of potentially returning direct cache references in query results. Since doing this isn't currently planned, and there have been many requests to make query results mutable, this commit disables query result deep freezing.
Fixes #1909.