Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify asynchronous persistCache method #3919

Merged
merged 4 commits into from
Sep 18, 2018
Merged

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Sep 15, 2018

Not treating persistCache as a promise leads to race conditions. I was having the same issue as described here apollographql/apollo-cache-persist#30 (comment)

@apollo-cla
Copy link

@bkucera: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clarification @bkucera - thanks!

@hwillson hwillson merged commit db6abff into apollographql:master Sep 18, 2018
@kuceb kuceb deleted the patch-2 branch October 10, 2018 04:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants