Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored query transformer (Issue #373) #412

Merged
merged 5 commits into from
Jul 18, 2016
Merged

Refactored query transformer (Issue #373) #412

merged 5 commits into from
Jul 18, 2016

Conversation

amandajliu
Copy link
Contributor

@amandajliu amandajliu commented Jul 18, 2016 •
edited
Loading

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo stubailo self-assigned this Jul 18, 2016
stubailo
stubailo reviewed Jul 18, 2016
View reviewed changes
CHANGELOG.md
@@ -3,13 +3,17 @@
Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 3 to 6 months), to signal the start of a more stable API.

### vNEXT

- Include fragments in query transformers, and new methods that allow transforming query document with multiple query transformers. [Issue #373](https://github.com/apollostack/apollo-client/issues/373) [PR #412](https://github.com/apollostack/apollo-client/pull/412)
Copy link
Contributor

@stubailo stubailo Jul 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase the first sentence as "make sure query transformers are also applied to named fragments."

@stubailo
Copy link
Contributor

this looks great! Just some nitpicky things.

@stubailo stubailo assigned amandajliu and unassigned stubailo Jul 18, 2016
@stubailo
Copy link
Contributor

Rebased this branch

@stubailo stubailo merged commit 0c444d4 into master Jul 18, 2016
@stubailo stubailo mentioned this pull request Jul 18, 2016
Closed
4 tasks
@stubailo stubailo deleted the transformer-refactor branch September 20, 2016 03:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@amandajliu amandajliu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amandajliu @stubailo