Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code sample reflects params for withClientState #4255

Merged
merged 3 commits into from
Jan 3, 2019

Conversation

haysclark
Copy link
Contributor

apollo-link-state's withClientState() method expects a string or array of typeDefs.

Users that copy and paste the previous code sample's typeDef object will encounter runtime warnings when it is parsed by withClientState(). This updated version parses correctly with no warnings and matches the apollo-link-state example code:
https://github.com/apollographql/apollo-link-state/blob/master/examples/todo/src/index.js#L13-L29

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

apollo-link-state's withClientState() method expects a string or array of typeDefs.
@apollo-cla
Copy link

@haysclark: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haysclark!

@hwillson hwillson merged commit 14333c8 into apollographql:master Jan 3, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants