-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Waiting for #374] Add fetchMore method to the observable query #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rricard
changed the title
Add fetchMore method to the observable query
[WIP] Add fetchMore method to the observable query
Jul 22, 2016
rricard
changed the title
[WIP] Add fetchMore method to the observable query
[Waiting for #374] Add fetchMore method to the observable query
Jul 22, 2016
I'll try to take a look on Monday. Thanks for the pointers! |
rricard
force-pushed
the
basic-fetch-more
branch
from
July 26, 2016 12:08
38ef025
to
6e2f067
Compare
rricard
force-pushed
the
strip-apollo-directives
branch
from
July 26, 2016 12:45
d6c0f0d
to
c86d092
Compare
This one will notify the QueryManager there are some `fetchMoreLocations` to get and concat. You can optionally carry some variables (but it is not interesting to do so until #453 is properly merged)
That way we'll be able to use it later in the write to the store
And test it! Concatenation is enough in a basic fetchMore setting. For now, let's just advise people to re-sort at rendering-level!
And tested! Needs to be tested on more complex stuff now!
This breaks automatically the testing suite since some are too complex to get green. Next commit is about fixing that...
By looking of ID fields we can handle complex cases such as updating at the same time two nested arrays.
One test is still failing, I need to go update an another branch for that ...
rricard
force-pushed
the
basic-fetch-more
branch
from
July 26, 2016 12:58
dfdf338
to
04a7e17
Compare
For now the test will be skipped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Linked to the work of #350
Usage example
You can't control the order in which the data is merged, that's why, for now, you should define the order in your rendering function. A next PR may change that but we have the issue of serialising functions into the store ...
Usage example after #453