Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve networkStatus for incomplete cache-and-network queries. #4765

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Preserve networkStatus for incomplete cache-and-network queries. #4765

merged 3 commits into from
Apr 30, 2019

Commits on Apr 30, 2019

  1. Preserve networkStatus for incomplete cache-and-network queries. 

    Blindly setting networkStatus to NetworkStatus.loading after the client
part of a cache-and-network query was destroying useful information about
the status of the request. Instead, we should use NetworkStatus.ready only
when the request is complete, and leave networkStatus untouched otherwise.

Fixes #3660, #4693, and apollographql/react-apollo#1217.
    @benjamn
    benjamn committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    ab7a908 View commit details
    Browse the repository at this point in the history

  2. Tweak: use storeValue variable instead of this.store[queryId].

    @benjamn
    benjamn committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    665d56d View commit details
    Browse the repository at this point in the history

  3. Mention PR #4765 in CHANGELOG.md.

    @benjamn
    benjamn committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    168af1f View commit details
    Browse the repository at this point in the history