Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'cache-and-network' definition to FetchPolicy #4878

Closed
wants to merge 1 commit into from

Conversation

Fonger
Copy link

@Fonger Fonger commented May 29, 2019

re: trojanowski/react-apollo-hooks#163

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@Fonger: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@sgoll
Copy link

sgoll commented May 30, 2019

I think a better way to solve the issue at hand (trojanowski/react-apollo-hooks#163) would be to use the new type WatchQueryFetchPolicy as useQuery uses watchQuery under the hoods (instead of query where cache-and-network cannot be implemented).

Cf. #3130 (comment) for details.

PS: I now see this approach has already been taken in PR trojanowski/react-apollo-hooks#165.

@hwillson
Copy link
Member

hwillson commented Sep 4, 2019

Thanks for this PR @Fonger. We prefer the approach outlined in #4878 (comment) to work around this issue. Thanks again!

@hwillson hwillson closed this Sep 4, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants