Hoist cache.modify method declaration to ApolloCache. #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6350 (comment) The modify method and its related types are fairly InMemoryCache-specific, which is why it felt safest to confine cache.modify to InMemoryCache when I brought it back in #6350. In practice, however, that confinement just makes cache.modify harder to use (annoyingly, not helpfully) in cases where an ApolloCache is all that's available. You could also argue that cache.modify has roughly the same standing (in terms of InMemoryCache-specificity) as cache.identify or cache.gc, which are also part of the "Optional API" of the ApolloCache base class. In that sense, cache.modify is simply joining those other AC3 APIs in ApolloCache.
benjamn
commented
May 29, 2020
| @@ -33,6 +34,13 @@ export namespace Cache { | |||
| broadcast?: boolean; | |||
| } | |||
|
|
|||
| export interface ModifyOptions { | |||
There was a problem hiding this comment.
Feels right to have Cache.ModifyOptions declared alongside Cache.EvictOptions again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #6350 (comment)
The
cache.modifymethod and its related types are fairlyInMemoryCache-specific, which is why it felt safest to confinecache.modifytoInMemoryCachewhen I brought it back in #6350. In practice, however, that confinement just makescache.modifyharder to use (annoyingly, not helpfully) in cases where anApolloCacheis all that's available.You could also argue that
cache.modifyhas roughly the same standing (in terms ofInMemoryCache-specificity) ascache.identifyorcache.gc, which are also part of the "Optional API" of theApolloCachebase class. In that sense,cache.modifyis simply joining those other AC3 APIs as part ofApolloCache(and thus alsoInMemoryCache).