Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge QueryBaseOptions, QueryOptions, and ModifiableQueryOptions into one type. #7136

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

DCtheTall
Copy link
Contributor

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@DCtheTall: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@DCtheTall
Copy link
Contributor Author

This PR fixes #6177

@DCtheTall
Copy link
Contributor Author

@hwillson friendly ping 😄

@benjamn benjamn self-assigned this Oct 27, 2020
@benjamn benjamn changed the base branch from main to release-3.3 October 27, 2020 19:16
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, @DCtheTall!

I changed the target branch to release-3.3 just because the removal of QueryBaseOptions (which was exported) could theoretically be a disruptive change, but I don't anticipate that being a problem for many people, and the fix is easy (just use QueryOptions instead).

@benjamn benjamn added this to the Post 3.0 milestone Oct 27, 2020
@benjamn benjamn merged commit 3af8775 into apollographql:release-3.3 Oct 27, 2020
@DCtheTall
Copy link
Contributor Author

I changed the target branch to release-3.3 just because the removal of QueryBaseOptions (which was exported) could theoretically be a disruptive change, but I don't anticipate that being a problem for many people, and the fix is easy (just use QueryOptions instead).

@benjamn totally understand/agree. I did a search on GitHub for its usage and found it is used virtually nowhere, but I can understand the desire to gate a potentially breaking change behind a release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants