Update ts-invariant and export setLogVerbosity from @apollo/client/core. #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
Oct 23, 2020
Comment on lines
+2825
to
+2830
| "dependencies": { | ||
| "ts-invariant": { | ||
| "version": "0.4.4", | ||
| "resolved": "https://registry.npmjs.org/ts-invariant/-/ts-invariant-0.4.4.tgz", | ||
| "integrity": "sha512-uEtWkFM/sdZvRNNDL3Ehu4WVpwaulhwQszV8mrtcdeE8nN00BV9mAmQ88RkrBhFgl9gMgvjJLAQcZbnPXI9mlA==", | ||
| "dev": true, |
There was a problem hiding this comment.
These outdated ts-invariant dependencies are all coming from graphql-tools, and all of them are "dev": true, so I don't think it will be a problem that the setLogVerbosity function has no effect on them.
This was referenced Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our
ts-invariantpackage allows configuration of logging verbosity forinvariant.log,invariant.warn, andinvariant.error, this PR re-exports that API from@apollo/client/core, so you can (for example) silence all warnings with the following code:If you want to silence errors as well,
setLogVerbosity("silent")will do that. We don't currently useinvariant.loganywhere, but we now have the freedom to be even more verbose with our logging, sinceinvariant.logmessages are hidden by default.