Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent RenderPromises memory leak by calling renderPromises.clear() after getMarkupFromTree finishes. #7943

Merged
merged 4 commits into from
Apr 5, 2021
Merged

Prevent RenderPromises memory leak by calling renderPromises.clear() after getMarkupFromTree finishes. #7943

merged 4 commits into from
Apr 5, 2021

Commits on Apr 2, 2021

  1. Failing test of RenderPromises QueryInfo garbage collection. 

    This is my best guess at a reproduction of issue #7942, given the heap
snapshot traces provided by @AlexMost.
    @benjamn
    benjamn committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    2190040 View commit details
    Browse the repository at this point in the history

  2. Call renderPromises.clear() at end of getDataFromTree work. 

    Should fix #7942 and the tests I added in my previous commit.
    @benjamn
    benjamn committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    d75bed8 View commit details
    Browse the repository at this point in the history

  3. Mention PR #7943 in CHANGELOG.md.

    @benjamn
    benjamn committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    2119e6f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Merge branch 'main' into 7942-RenderPromises-memory-leak

    @benjamn
    benjamn authored Apr 5, 2021
    Configuration menu
    Copy the full SHA
    9c75a93 View commit details
    Browse the repository at this point in the history