Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nullable connections in relayStylePagination #7949

Closed

Conversation

lukel97
Copy link

@lukel97 lukel97 commented Apr 5, 2021

This handles my edge case in #7822 (comment) where a nullable connection with a field policy set to relayStylePagination would throw an error whenever a null existing/incoming node was handled. The fix is pretty bone-headed, so if there's a better way to go about fixing this please let me know!

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@bubba: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@lukel97 lukel97 force-pushed the fix-relaystylepagination-nulls branch from f6bed46 to eb3bb30 Compare April 5, 2021 15:18
@lukel97 lukel97 force-pushed the fix-relaystylepagination-nulls branch from eb3bb30 to a790268 Compare April 6, 2021 14:06
@lukel97
Copy link
Author

lukel97 commented May 20, 2021

Bump

@benjamn
Copy link
Member

benjamn commented Aug 30, 2021

@bubba I took the liberty of rebasing this branch against main and making a few changes in #8733, preserving your authorship. Closing in favor of that PR (though maybe consider enabling pushes from maintainers when you open future PRs, if you want us to be able to push commits to your branch). Thanks!

@benjamn benjamn closed this Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants