Update typescript to v4.3.3 #8394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainkim
reviewed
Jun 17, 2021
brainkim
approved these changes
Jun 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6886.
As of this writing,
@apollo/client@betashould support[email protected]and later, by avoiding any type system features in.d.tsfiles that are not understood by TS 3.7.Until this PR, we have been using
[email protected]to build@apollo/clientand run its tests, ensuring compatibility with that version of TypeScript (v3.9.9), at the very least.Despite the upgrade to v4.3.3 in this PR, we intend to continue supporting older v3.x versions of
typescript, unless there is a compelling reason to use recently added syntax in externally visible type declarations. One such compelling feature: TypeScript v3.8 would be required to support type-onlyimport type { ... } from ...declarations.