Align NetworkError and GraphQLErrors types #8424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
Application-wide networkError error handler fails with error:
Seems to be due to:
ApolloError
networkError haveError | ServerParseError | ServerError | null
type:But the same networkError in ErrorResponse have
Error | ServerError | ServerParseError
type:The difference is in
null
. To keep backward compatibility as much as possible, I am addingnull
to LinkErrorResponse
interface.The next step may be to remove
null
and make it optional.