Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssr: false causing queries to hang #8574

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Fix ssr: false causing queries to hang #8574

merged 3 commits into from
Aug 2, 2021

Conversation

brainkim
Copy link
Contributor

@brainkim brainkim commented Aug 2, 2021

Fixes #8571

@brainkim brainkim requested a review from benjamn August 2, 2021 20:16
@brainkim brainkim changed the title Brian ssr false Fix ssr: false causing queries to hang Aug 2, 2021
benjamn
benjamn approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I can confirm this fixes the reproduction from #8571.

@brainkim Could you add a CHANGELOG.md entry before merging?

@benjamn benjamn added this to the v3.4.x patch releases milestone Aug 2, 2021
@brainkim brainkim merged commit 5956a38 into main Aug 2, 2021
@brainkim brainkim deleted the brian-ssr-false branch August 2, 2021 21:00
@hwillson hwillson added 2021-07 and removed 2021-07 labels Aug 3, 2021
@benjamn benjamn mentioned this pull request Aug 26, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.5.x patch releases
Development

Successfully merging this pull request may close these issues.

useQuery with {ssr: false} is not fetched on client-side
3 participants
@brainkim @benjamn @hwillson