-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable chaining for middlewares and afterwares in the network interface - Issue 564 #860
Conversation
Hi,
Regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot! Just one tiny change requested.
@@ -3,6 +3,7 @@ | |||
Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 3 to 6 months), to signal the start of a more stable API. | |||
|
|||
### vNext | |||
- **new Feature**: In network interface, enable chaining the `use` and `useAfter` functions, respectively. [PR #860](https://github.com/apollostack/apollo-client/pull/860) [Issue #564](https://github.com/apollostack/apollo-client/issues/564) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we simplify this to "Enable chaining of use
and useAfter
function calls in network interface"?
…or use().useAfter() and useAfter().use()
Just added a new commit that includes the required change + two new tests for testing use(...).useAfter(...) and useAfter(...).use(...) chaining. |
Here is a link to a PR on apollostack/core-docs which documents this feature : |
For me, this PR is ready to be merged but tell me if some changes need to be done. |
Looks good to me. Thanks a lot @oricordeau ! |
TODO: