-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log MissingFieldError
s in ObservableQuery#getCurrentResult
rather than using result.error
#8604
Log MissingFieldError
s in ObservableQuery#getCurrentResult
rather than using result.error
#8604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would help my team's issues a lot, thank you for the quick turnaround!
3502c1a
to
50e0413
Compare
is there a way to suppress this manually for the time being until this is shipped? |
Two non-blocking questions:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Should fix #8593, which suggests including `MissingFieldError`s in `result.error` was more disruptive than helpful.
6091a3e
to
1e8f677
Compare
Should fix #8593, which suggests our decision in #8262 to include
MissingFieldError
s inresult.error
(beginning in@apollo/[email protected]
) was probably more disruptive than helpful.