Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and expose MutationOptions ;) #866

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Conversation

kamilkisiela
Copy link
Contributor

@kamilkisiela kamilkisiela commented Nov 2, 2016

Would help a lot with things like this
kamilkisiela/apollo-angular#141 (comment)

Copy link
Contributor

@helfer helfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename these to MutationOptions? I want to standardize everything to QueryX, MutationX, SubscriptionX.

@kamilkisiela
Copy link
Contributor Author

@helfer done

@helfer
Copy link
Contributor

helfer commented Nov 2, 2016

@kamilkisiela I meant in the code as well 😉

@kamilkisiela
Copy link
Contributor Author

kamilkisiela commented Nov 2, 2016

@helfer :D that's right, forgot to rename it :D

@kamilkisiela kamilkisiela changed the title Create and expose MutateOptions Create and expose MutationOptions ;) Nov 2, 2016
@kamilkisiela
Copy link
Contributor Author

@helfer now should be okay, long day...

@helfer
Copy link
Contributor

helfer commented Nov 2, 2016

Thanks, lgtm!

@helfer helfer merged commit 90a24bf into master Nov 2, 2016
@kamilkisiela kamilkisiela deleted the expose-mutate-options branch November 2, 2016 22:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants