Improve keyFields error behavior when primary key fields are missing
#8679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
force-pushed
the
allow-directives-and-variables-in-field-key-policy
branch
from
adc3b73
to
0c4c008
Compare
Base automatically changed from
allow-directives-and-variables-in-field-key-policy
to
release-3.5
August 25, 2021 21:37
Should help with `cache.identify`-related cases of issue #6673.
benjamn
force-pushed
the
improve-keyFields-error-behavior
branch
from
30857d7
to
e1b737f
Compare
hwillson
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #8678 (only because it touches the same code), this PR seeks to improve the way
computeKeyFieldsObjectbehaves when it fails, in two ways:cache.identifymethod (which ultimately callscomputeKeyFieldsObjectwhenkeyFieldsis configured) will no longer throw under any circumstances, instead returning undefined to indicate failure (as usual).computeKeyFieldsObjectfails will now include the object that was missing the desired field, making it much easier to tell why the error happened (as suggested by @jorbuedo in keyFields mismatch with query leads to hard Invariant Violation crash #6673 (comment)).This may not be a full solution to #6673, but I'm sure it will help.