Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zen-observable-ts to eliminate transitive dependency on @types/zen-observable #8695

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Aug 24, 2021

This update includes apollographql/zen-observable-ts#152, and should fix issue #8688 because Apollo Client no longer generates code in dist/**/*.d.ts files with type references to the @types/zen-observable package:

/// <reference types="zen-observable" />

With these references gone, consumers of zen-observable-ts should not need to add @types/zen-observable as a dependency. In fact, the @types/zen-observable package is no longer involved at all. Thus, #8688 should be fixed.

Since this could be a disruptive type-level change for anyone who was previously depending on the global declaration of the ZenObservable namespace, I'm targeting the release-3.5 branch so we can test before releasing.

@benjamn benjamn self-assigned this Aug 24, 2021
@benjamn benjamn requested a review from brainkim August 24, 2021 19:18
@benjamn benjamn changed the title Update zen-observable-ts to fix issue #8688 Update zen-observable-ts to eliminate transitive dependency on @types/zen-observable Aug 24, 2021
@benjamn benjamn added this to the Release 3.5 milestone Aug 24, 2021
@brainkim
Copy link
Contributor

LGTM

@benjamn benjamn merged commit ed9f5cb into release-3.5 Aug 24, 2021
@benjamn benjamn deleted the update-zen-observable-to-fix-issue-8688 branch August 24, 2021 19:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants