-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ssrMode #8709
Merged
Merged
Fix ssrMode #8709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainkim
force-pushed
the
brian-ssr-fixes
branch
from
August 26, 2021 22:46
aa7b1ea
to
8a2bbed
Compare
hwillson
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @brainkim, thanks for digging into this!
benjamn
reviewed
Aug 27, 2021
brainkim
force-pushed
the
brian-ssr-fixes
branch
3 times, most recently
from
August 27, 2021 18:51
38f159c
to
167eee1
Compare
brainkim
force-pushed
the
brian-ssr-fixes
branch
from
August 27, 2021 18:53
167eee1
to
efc6096
Compare
brainkim
force-pushed
the
brian-ssr-fixes
branch
from
August 27, 2021 21:00
efc6096
to
a6d7786
Compare
@benjamn Split out the small fixes from the large fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes:
when ssrMode is set to true, client side pollInterval is not enabled #8310ssrForceFetchDelay
option causes useQuery calls to hang. #8644