Require cache.reset({ discardWatches: true })
to clear cache.watches
#8852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue #8851 by @tm1000, PR #8826 (shipped in v3.4.14) was a breaking change for code expecting
cache.watches
to be restarted aftercache.reset()
is called.This commit establishes a small but extensible
Cache.ResetOptions
API for thecache.reset
method, which allows the handling of watches to be configured viaoptions.discardWatches
, which defaults tofalse
, thus restoring the behavior ofcache.reset()
from before #8826.If you need the behavior introduced by #8826, you can now opt (back) into that behavior by calling