Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ensure only current file is run with VSCode debugger #9050

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Nov 12, 2021

Without this change having open e.g. src/react/hoc/__tests__/mutations/queries.test.tsx running "Jest Current File" from VSCode's "Run and Debug" would result in /usr/bin/node ./node_modules/.bin/jest queries.test --config ./config/jest.config.js. However, this would match multiple files (here src/react/hoc/__tests__/mutations/recycled-queries.test.tsx and src/react/hoc/__tests__/mutations/queries.test.tsx.

With this change we ensure that only a single file is run.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@eps1lon: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense—thanks for improving this configuration @eps1lon!

@benjamn benjamn added this to the v3.5.x patch releases milestone Nov 16, 2021
@benjamn benjamn merged commit bd7abc3 into apollographql:main Nov 16, 2021
@eps1lon eps1lon deleted the chore/jest-file branch November 17, 2021 00:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants