Commits on Feb 3, 2022

1. Temporarily revert useSyncExternalStore changes (#8785). …

   This reverts commit 7f0d459 and
   follow-up commit 5328dae (move
   onCompleted and onError to the snapshot function).
   
   Because there have been several merges on release-3.6 since those
   commits, and some of those merges involve useSyncExternalStore-related
   code, I was not able to obtain a good state simply by reverting the
   commits and manually resolving the conflicts.
   
   Instead, I removed the commits during an interactive Git rebase, using
   --rebase-merges to replay/recreate merge commits (rather than dropping
   them, as rebase usually does). Once I verified tests were passing after
   this rebase, I constructed the current commit from the difference
   between the branches, which should allow us to keep the current history
   from before the rebase, with this commit achieving the same final state
   as after the rebase.
   
   We will cherry-pick the inverse of this commit onto a new release-3.7
   branch soon, so we can continue releasing v3.6 betas without the
   risk/complexity introduced by useSyncExternalStore. We are still
   committed to implementing that API and fully supporting React 18, with
   prerelease availability continuing in the v3.7 betas.

   

   benjamn committed Feb 3, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 38b129e
   • Browse repository at this point

   Copy the full SHA

   38b129e View commit details

   Browse the repository at this point in the history