Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #9369 to main branch for GraphQLWsLink and @apollo/client/link/subscriptions #9453

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Backport PR #9369 to main branch for GraphQLWsLink and @apollo/client/link/subscriptions #9453

merged 2 commits into from
Feb 24, 2022

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Feb 24, 2022 •
edited
Loading

This PR back-ports the new GraphQLWsLink contributed by @glasser in #9369 for release in the next Apollo Client patch version, 3.5.10.

@benjamn
Merge pull request #9369 from apollographql/glasser/graphql-ws
6ef4fa4 
New GraphQLWsLink for graphql-ws subscriptions library
@benjamn benjamn added 🔗 apollo-link 🚠 backport 🥚 backwards-compatible for PRs that do not introduce any breaking changes labels Feb 24, 2022
@benjamn benjamn added this to the v3.5.x patch releases milestone Feb 24, 2022
@benjamn benjamn self-assigned this Feb 24, 2022
glasser
glasser reviewed Feb 24, 2022
View reviewed changes
Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that other than the note added to CHANGELOG and maybe some conflicts in package/package-lock, everything applied cleanly?

package.json Outdated Show resolved Hide resolved
@benjamn
Copy link
Member Author

benjamn commented Feb 24, 2022

Yep, only CHANGELOG.md and package{,-lock}.json were conflicted.

@benjamn benjamn merged commit ce90c47 into main Feb 24, 2022
@benjamn benjamn deleted the backport-GraphQLWsLink-to-main branch February 25, 2022 17:43
@benjamn benjamn mentioned this pull request Mar 30, 2022
Closed
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glasser glasser glasser approved these changes

@hwillson hwillson Awaiting requested review from hwillson

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees

@benjamn benjamn

Labels
🔗 apollo-link 🚠 backport 🥚 backwards-compatible for PRs that do not introduce any breaking changes
Projects
None yet
Milestone
v3.5.x patch releases
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamn @glasser