-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type policy inheritance #9905
Type policy inheritance #9905
Conversation
👋 @alessbell @MrDoomBringer @hwillson @benjamn Here's an attempt to document this feature! Could someone provide a quick review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @jpvajda! 🎉 I'm wondering if this section would be better suited in another part of the docs, like maybe in https://www.apollographql.com/docs/react/caching/cache-field-behavior or even https://www.apollographql.com/docs/react/caching/advanced-topics. Type policy inheritance is more of an intermediate to advanced topic so putting it on one of the first configuring the cache pages might me a little off-putting to newcomers.
@hwillson Thanks for the review! I was thinking advanced topics would be a good location for this as well, so let me move this section. |
@hwillson all set for a fresh review. 🤜 🤛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one nit, otherwise LGTM!
Co-authored-by: alessia <[email protected]>
This PR attempts to documented the TypePolicy Inheritance feature introduced in #7065