Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v4.0.0-rc.2 changelog #6064

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Add v4.0.0-rc.2 changelog #6064

merged 3 commits into from
Jul 22, 2024

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jul 22, 2024

No description provided.

@BoD BoD requested a review from martinbonnin as a code owner July 22, 2024 09:08
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 696c65b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/669e363c392f140008c03762

@@ -1,6 +1,24 @@
Change Log
==========

# Version v4.0.0-rc.2

We're on the road to v4 with this second release candidate which includes a few minor tweaks as well as one new feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like something needs to be said about 4.0.0-rc.2 using 4.0.0-rc.1 in apollo-tooling and apollo-debug-server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this transparent for users though? Gradle should resolve apollo-runtime to 4.0.0-rc.2, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is the first one to have everything in the com.apollographql.apollo package name.

The previous one would duplicate apollo-api in some cases because of this.

Gradle should resolve apollo-runtime to 4.0.0-rc.2, right?

Correct. If no version is set by the user then AKGP uses the same version as itself but that doesn't help about apollo-debug-server pulling apollo3 dependencies.

@BoD BoD merged commit 29434df into main Jul 22, 2024
1 check passed
@BoD BoD deleted the changelog-v4.0.0-rc.2 branch July 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants