This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Remove reference to GlobalFetch in Typescript #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation of apollo-link-http-common in the upcoming Typescript 3.6. Fixes apollographql#1094
|
@sandersn: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
======================================
Coverage 95.6% 95.6%
======================================
Files 22 22
Lines 1116 1116
Branches 174 162 -12
======================================
Hits 1067 1067
Misses 44 44
Partials 5 5
Continue to review full report at Codecov.
|
sandersn
added a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jun 19, 2019
1. Apollo-link used GlobalFetch, which has been removed. Until my PR goes in (apollographql/apollo-link#1095), I added a shim in apollo-upload-client, which uses apollo-link-http-common. 2. dom-inputevent is updated to match the spec-standard InputEvent types that will ship with Typescript 3.6. 3. Same for webappsec-credential-management 4. Fixed to-markdown's tests to work with the new, non-nullable definition of node.style.fontStyle.
|
@benjamn It doesn't look like all the circleci tasks are running. Is it backlogged or something? The build succeeded but Filesize, Monorepo, Prettier, etc have not started. |
iRON5
pushed a commit
to iRON5/DefinitelyTyped
that referenced
this pull request
Aug 13, 2019
* Fixes for early June TS3.6 DOM update 1. Apollo-link used GlobalFetch, which has been removed. Until my PR goes in (apollographql/apollo-link#1095), I added a shim in apollo-upload-client, which uses apollo-link-http-common. 2. dom-inputevent is updated to match the spec-standard InputEvent types that will ship with Typescript 3.6. 3. Same for webappsec-credential-management 4. Fixed to-markdown's tests to work with the new, non-nullable definition of node.style.fontStyle. * Fix redundant `undefined` lint * Make fetch shim work on more versions of Typescript * Require TS 3.1 for apollo-upload-client fix
|
^ 🙏 In the meantime... Is there any workaround? |
|
@sarink @akleiner2 The latest release fixed the issue for us |
This was referenced Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation of apollo-link-http-common in the upcoming Typescript 3.6.
Fixes #1094
There is no new test for this -- if it builds then it works with whatever version of Typescript is on CI; if apollo-link doesn't already test with multiple versions of TS then I don't think this is the place to make that happen.