Skip to content

Commit

Permalink
Modify mentions of Engine to Graph Manager (in error messages,… (#3276)
Browse files Browse the repository at this point in the history
* Modify mentions of Engine to Graph Manager

This does not rename anything that is specifically Apollo Engine
Reporting, the Engine config, or Apollo Engine proxy, but changes other
mentions to align with rebranding.

* Apply suggestions from code review

Take suggestion of referencing previous names

Co-Authored-By: Jesse Rosenberger <[email protected]>

* Partially revert changes to errors in 248b440.
  • Loading branch information
zionts authored and abernix committed Oct 8, 2019
1 parent f805c71 commit e6ef179
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions packages/apollo-engine-reporting-protobuf/README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# `apollo-engine-reporting-protobuf`

> **Note:** The Apollo Engine reporting API is subject to change. We strongly
> encourage developers to contact Apollo Engine support to discuss their use
> **Note:** The Apollo Graph Manager (previously, Apollo Engine) reporting API is subject to change. We strongly
> encourage developers to contact Apollo Graph Manager support to discuss their use
> case prior to building their own reporting agent using this module.
This module provides JavaScript/TypeScript
[Protocol buffer](https://developers.google.com/protocol-buffers/) definitions
for the Apollo Engine reporting API. These definitions are generated for
for the Apollo Graph Manager reporting API. These definitions are generated for
consumption from the `reports.proto` file which is defined internally within
Apollo.

Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-engine-reporting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
[![npm version](https://badge.fury.io/js/apollo-engine-reporting.svg)](https://badge.fury.io/js/apollo-engine-reporting)
[![Build Status](https://circleci.com/gh/apollographql/apollo-server.svg?style=svg)](https://circleci.com/gh/apollographql/apollo-server)

This package is a pure JS implementation of the Apollo Engine reporting feature. It enables aggregated reporting in stateful environments and sending single reports for stateless environments.
This package is a pure JS implementation of the Apollo Graph Manager (previously, Apollo Engine) reporting feature. It enables aggregated reporting in stateful environments and sending single reports for stateless environments.
2 changes: 1 addition & 1 deletion packages/apollo-engine-reporting/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "apollo-engine-reporting",
"version": "1.4.6",
"description": "Send reports about your GraphQL services to Apollo Engine",
"description": "Send reports about your GraphQL services to Apollo Graph Manager (previously known as Apollo Engine)",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
"license": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions packages/apollo-server-core/src/ApolloServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,8 @@ export class ApolloServerBase {
// metrics from the Gateway.
console.warn(
"It looks like you're running a federated schema and you've configured your service " +
'to report metrics to Apollo Engine. You should only configure your Apollo gateway ' +
'to report metrics to Apollo Engine.',
'to report metrics to Apollo Graph Manager. You should only configure your Apollo gateway ' +
'to report metrics to Apollo Graph Manager.',
);
}
extensions.push(() =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ export function testApolloServer<AS extends ApolloServerBase>(
});

describe('lifecycle', () => {
describe('for Apollo Engine', () => {
describe('for Apollo Graph Manager', () => {
let nodeEnv: string;
let engineServer: EngineMockServer;

Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-tracing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This package is used to collect and expose trace data in the [Apollo Tracing](ht

It relies on instrumenting a GraphQL schema to collect resolver timings, and exposes trace data for an individual request under `extensions` as part of the GraphQL response.

This data can be consumed by [Apollo Engine](https://www.apollographql.com/engine/) or any other tool to provide visualization and history of field-by-field execution performance.
This data can be consumed by [Apollo Graph Manager](https://www.apollographql.com/platform/) (previously, Apollo Engine) or any other tool to provide visualization and history of field-by-field execution performance.

## Usage

Expand Down

0 comments on commit e6ef179

Please sign in to comment.