Apollo Server 2.0 #1125
Merged
Apollo Server 2.0 #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
📝 documentation
| }); | ||
|
|
||
| // Additional middleware can be mounted at this point to run before Apollo. | ||
| app.use('*', jwtCheck, requireAuth, checkScope); |
There was a problem hiding this comment.
Oh I see that you have this documented here. Thanks @evans
|
This is a really huge PR. @evans do you have an ETA for getting this merged or will you break it into smaller PRs? |
4 tasks
* Add BadUserInputError and TransientError as extensions of ApolloError * remove TransientError * update test so that properties end up under `error.extensions.exception` * update documentation to talk about BadUserInputError * check for properties after formatApolloErrors has been called * fixed highlighted lines for docs * export BadUserInputError from `apollo-server` * fixed highlighted lines for docs * export BadUserInputError from `apollo-server` * update changelog
packages/apollo-server/package.json
Outdated
| @@ -35,6 +35,7 @@ | |||
| "dependencies": { | |||
| "apollo-server-core": "^2.0.0-beta.6", | |||
| "apollo-server-express": "^2.0.0-beta.6", | |||
| "express": "^4.0.0", | |||
There was a problem hiding this comment.
Not really an issue and probably not worth fixing now, but unless we keep the versions between apollo-server and apollo-server-express in sync this does lead to a Lerna warning:
lerna WARN EHOIST_PKG_VERSION "apollo-server-express" package depends on [email protected], which differs from the hoisted express@^4.0.0.
* Add a wider diversity of `gui` options Although I know we want to remain less tied to the GraphQL Playground GUI options, we definitely want to support a wider variety of options to be passed in. This adds support for specifying partial options either statically or dynamically for the gui, which can be extended to allow for a wider array of guis than only GraphQL playground. * Add boolean option and configuration for tabs * move gui setting into ApolloServer Constructor * document playground configuration in the constructor * update playground types and fixed micro + koa integrations * change gui to playground * docs: change gui to playground * fix logic for playground creation
* remove formatParams * remove formatParams from documentation * check for valid query string after persisted query mapping * fix sentence about different logging and label extensions as experimental * mark graphql-extensions as more experimental
applyMiddleware is not a public api for apollo-server, so it should not be used an direct people to the apollo-server-express integration.
It only lived here for one day, but this particular link wasn't updated!
Merge master
This updates all blog URLs in the documentation to use blog.apollographql.com as the domain, rather than dev-blog.apollodata.com.
4 tasks
abernix
added a commit
that referenced
this pull request
Feb 5, 2019
Fixes issue introduced in #1125 and logged in #2186 and #2196. Arrays are valid JSON per spec: https://tools.ietf.org/html/rfc7159
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to land the revival of the apollo-server package as a new entry point for building GraphQL servers. apollo-server seeks to take an opinionated approach to building GraphQL services. The apollo-server-{integration} packages provide the ability to customize the behavior of the apollo-server for different environments or frameworks.
Apollo server also provides the tooling from graphql-tools and graphql-subscriptions, includes custom schema and service runtime additions (initially production validation rules for turning off introspection and more guidance around error handling).
This is the kickoff of a new generation of work on building production ready GraphQL services♥️
The approach supersedes #979 and is used in favor of #1063, since it deploys the docs directly to the v2 page
rc.5 -> rc.6
formatError(Errors Lifecycle: user extensions > engine reporting > formatError #1272)formatErroronly called once on validation errors (Errors Lifecycle: user extensions > engine reporting > formatError #1272)rc.4 -> rc.5
rc.3 -> rc.4
rc.2 -> rc.3
rc.1 -> rc.2
rc.0 -> rc.1
Data sources
Changes beta -> rc.1
registerServerchanged toserver.applyMiddleware(3279991)installSubscriptionHandlersChanges beta.3 -> beta.4
Bug fix to allow async context (#1129)
logFunction is now an extension (#1128)
Allow user defined extensions and include engine reporting (#1105 )
Changes beta.2 -> beta.3
remove registerServer configuration from
apollo-server's listen (#1090)move healthcheck into variants (#1086)
Add file uploads, breaking requires removing
scalar Uploadfrom the typeDefs (#1071)Add reporting to Engine as apollo-engine-reporting (#1105)
Allow users to define extensions (#1105)
Changes beta.1 -> beta.2
ListenOptions:
engine->engineProxyport,host, and other http options moved underhttpkey #1080subscriptionsmoved toserver.listen#1059Add mocks to server constructor #1017
Add
bodyParserConfigparameter toregisterServerin apollo-server #1059 commitHapi variant #1058 #1082