Attaches connectors to mocked schema #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attaches connectors even if schema is (partially) mocked. Adds tests.
|
@helfer Travis failed with NVM installation issues. Can you resubmit the build please? |
|
Thanks for this! |
evans
pushed a commit
that referenced
this pull request
Jul 3, 2018
* Allow `undefined` to return from `format`. TypeScript 2.7 introduced new "Strict Class Instantiation" rules which, as the name suggests, require properties which are intended to be set (eventually, to a type) be set during construction. Before this change, the `TracingExtension` class was deferred setting these private properties (namely, `startWallTime`, `endWallTime`, `startHrTime` and `duration`), but not during instantiation which required setting marking them as optional and guarding their usage in other methods which might use those (temporarily `undefined`, if even for a tick) properties. For example, the expectation that `format` is _only_ called after `requestDidStart` is not guaranteed with this configuration, even if it is expected under normal operation. Therefore, this change adds the additional guarding and updates the `format` method to return `undefined` in the event that it doesn't have the appropriate data. * Update `graphql-extensions` dependency to `~0.0.9`. Specifically, to take advantage of a type which landed in `[email protected]` thanks to https://github.com/apollographql/graphql-extensions/pull/10.
evans
added a commit
that referenced
this pull request
Jul 3, 2018
* Initial commit * 0.0.3 * Replace endOffset with duration in resolver calls * 0.0.4 * Fix duration * 0.0.5 * Remove unnecessary schema level resolve function and return schema * Update README * 0.0.6 * Update README * Update dependencies * 0.0.7 * Update README * set package.json to point to this repository (#3) * Update dependencies Fixes #4. * 0.0.8 * Add asynciterable support to tsconfig.json * Skip trace collection when context or context._traceCollector is undefined Fixes #5. * 0.0.9 * Rewrite to use graphql-extensions * 0.0.10 * 0.0.11 * 0.1.0 * Update graphql-extensions dependency and downgrade TS target * 0.1.1 * Update README * Update README * Increase version range for `graphql` peerDependency. (#7) * 0.1.2 * Update dependencies * 0.1.3 * [apollo-bot] Update the Issue/PR Templates with auto label (#9) * Update `graphql` peer dependency range to allow 0.13.x. * dev: Update TypeScript to latest version, v2.7.2. * dev: Update jest & dependencies to latest versions. * dev: Update type definitions for `graphql`, `node` and `jest`. * Allow `undefined` to return from `format`. (#12) * Allow `undefined` to return from `format`. TypeScript 2.7 introduced new "Strict Class Instantiation" rules which, as the name suggests, require properties which are intended to be set (eventually, to a type) be set during construction. Before this change, the `TracingExtension` class was deferred setting these private properties (namely, `startWallTime`, `endWallTime`, `startHrTime` and `duration`), but not during instantiation which required setting marking them as optional and guarding their usage in other methods which might use those (temporarily `undefined`, if even for a tick) properties. For example, the expectation that `format` is _only_ called after `requestDidStart` is not guaranteed with this configuration, even if it is expected under normal operation. Therefore, this change adds the additional guarding and updates the `format` method to return `undefined` in the event that it doesn't have the appropriate data. * Update `graphql-extensions` dependency to `~0.0.9`. Specifically, to take advantage of a type which landed in `[email protected]` thanks to https://github.com/apollographql/graphql-extensions/pull/10. * 0.1.4 * Update for [email protected] API (#13) * Upgrade to TypeScript 2.8 * Add tslint and prettier * Update for [email protected] API * 0.2.0-beta.0 * Make work with newest API usage format() now gets called before the requestDidStart() EndHandler. * 0.2.0-beta.1 * remove unused files from tracing package * upgrade packages, fix compilation bugs, and add test
evans
pushed a commit
that referenced
this pull request
Jul 3, 2018
evans
added a commit
that referenced
this pull request
Jul 3, 2018
* Initial commit * Add .npmignore to avoid ignoring lib when publishing * 0.0.2 * Update graphql-extensions dependency to 0.0.2 * 0.0.3 * Reorganize code and add tests * 0.0.4 * Add tests and reorganize code * 0.0.5 * Update dependency to graphql-extensions 0.0.4 * 0.0.6 * Update graphql-extensions dependency and downgrade TS target * 0.0.7 * Update README * Update README * Update README * Update README * Add import instructions for TypeScript to README (#7) * Add cache hints when the directive is defined on interfaces (#10) * Increase version range for `graphql` peerDependency. (#12) * 0.0.8 * Update dependencies * 0.0.9 * [apollo-bot] Update the Issue/PR Templates with auto label (#13) * [apollo-bot] Update the Templates with docs label (#15) * Add cache hints to info.cacheControl (#16) This exposes the `cacheControl` hints on the schema, to the resolvers at runtime. * Update `graphql` peer dependency range to allow 0.13.x. * dev: Update TypeScript to latest version, v2.7.2. * dev: Update jest & dependencies to latest versions. * dev: Update type definitions for `graphql`, `node` and `jest`. * dev: Update `graphql` to latest version, v0.13.2. * 0.0.10 * Add defaultMaxAge option This is an easy way to quickly say "I want everything in my schema to be cached for 5 seconds". You can override it with specific maxAges on specific fields or types. An upcoming release of apollo-server-* will allow you to specify options to cacheControl. * Add CircleCI config * Add partial CHANGELOG * 0.1.0 * Honor overwrite default maxAge with maxAge=0 (Fixes #22) (#23) * 0.1.1 * Allow default caching to apply to interfaces * remove unused files * update versions and use a-s style config * run prettier * fix tests and typing
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attaches connectors even if schema is (partially) mocked. Adds tests.