fix some badge links #1281
Merged
fix some badge links #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chentsulin
force-pushed
the
fix-some-badge-link
branch
from
d951c15
to
beffc71
Compare
evans
reviewed
Jul 2, 2018
There was a problem hiding this comment.
@chentsulin Thank you so much! This is definitely some much needed test clean up and linking.
There are a couple of badges that were missing a [ at the start. Once we add them, then we'll be able to merge!
Thank you again!
| @@ -1,5 +1,8 @@ | |||
| ## MemcachedCache | |||
|
|
|||
| ](https://badge.fury.io/js/apollo-server-memcached) | |||
packages/apollo-server/README.md
Outdated
| @@ -1,4 +1,7 @@ | |||
| # Apollo Server | |||
|
|
|||
| ](https://badge.fury.io/js/apollo-server) | |||
| # graphql-extensions | ||
|
|
||
| ](https://badge.fury.io/js/graphql-extensions) |
| @@ -1,5 +1,8 @@ | |||
| ## RedisCache | |||
|
|
|||
| ](https://badge.fury.io/js/apollo-server-redis) | |||
| @@ -1,4 +1,7 @@ | |||
| # apollo-server-core | |||
|
|
|||
| ](https://badge.fury.io/js/apollo-server-core) | |||
| @@ -1,3 +1,8 @@ | |||
| # apollo-server-caching | |||
|
|
|||
| ](https://badge.fury.io/js/apollo-server-caching) | |||
There was a problem hiding this comment.
It appears that we missed a [ at the start of the line
chentsulin
force-pushed
the
fix-some-badge-link
branch
from
beffc71
to
aceb93e
Compare
chentsulin
force-pushed
the
fix-some-badge-link
branch
from
aceb93e
to
d9dc4b1
Compare
|
@chentsulin Thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some wrong links in readme.