Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appolo-server-micro top level error response #1619

Conversation

fromthemills
Copy link
Contributor

@fromthemills fromthemills commented Sep 5, 2018

Fix for (#1581)

apollo-server-micro does not handle context or schema errors correctly. Instead of just throwing when error is caught the error message should be return as the response body.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@DriesVandermeulen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@fromthemills fromthemills force-pushed the fix-apollo-server-micro-error-response branch from 0f1401b to c848dd4 Compare September 5, 2018 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants