Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AER/Default to headers for client identity #1960

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

zionts
Copy link
Contributor

@zionts zionts commented Nov 14, 2018

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

lolwut

Revert "lolwut"

This reverts commit 03a2e10.
@zionts zionts force-pushed the adam/18/11/client-info-default-to-headers branch from 03a2e10 to 81d9f47 Compare November 14, 2018 01:36
@zionts zionts merged commit e40a2e9 into master Nov 14, 2018
@zionts zionts deleted the adam/18/11/client-info-default-to-headers branch November 14, 2018 01:51
@abernix
Copy link
Member

abernix commented Nov 14, 2018

@zionts Does this sound like an appropriate CHANGELOG entry?

A once suggested, slightly incorrect, now tweaked suggestion
When `generateClientInfo` is not used to define the client name, client version and
client reference ID, Apollo Server will default to the values present in the HTTP headers
of the request (`apollographql-client-name`, `apollographql-client-reference-id` and
`apollographql-client-version` respectively) and then, when those headers are not set,
the query extensions' `clientInfo` values. [PR #1960](https://github.com/apollographql/apollo-server/pull/1960)

Update: Done with a slightly different in 8f50045

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants