Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle a TTL of 0 correctly #2588

Merged
merged 3 commits into from
Apr 25, 2019
Merged

Conversation

sebnow
Copy link
Contributor

@sebnow sebnow commented Apr 18, 2019

When a TTL override of 0 is set, the override is overriden with the
policy due to using the || operator, which considers 0 to be false.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@sebnow: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

When a TTL override of 0 is set, the override is overriden with the
policy due to using the || operator, which considers 0 to be false.
@sebnow sebnow marked this pull request as ready for review April 18, 2019 14:52
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks!

@abernix abernix merged commit 0667c4b into apollographql:master Apr 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants