add test for @key referencing list #2941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
reviewed
Jun 28, 2019
| expect(errors).toHaveLength(0); | ||
|
|
||
| const warnings = validateKeyFieldsSelectInvalidType(schema); | ||
| expect(warnings).toMatchInlineSnapshot(`Array []`); |
There was a problem hiding this comment.
If this is supposed to be a warning, shouldn't the warning Array have something in it?
There was a problem hiding this comment.
Yep! That's what this PR is supposed to highlight. I'll add some more to the description
|
@trevor-scheer iirc, didn't we talk about removing that limitation from the docs since both the planner and validator already support list types in keys? |
@jbaxleyiii looks like we can close this one out via #2841. I'll poke around the docs and look for any references to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates a lack of validation errors for array types in the @-key directive.
Expected: validations provide a warning when list types are referenced by a @-key directive.
https://github.com/apollographql/apollo-server/compare/evans/broken-requires-list?expand=1#diff-80ddba2f8f972a6873ae15bd107da23eR151 should have values inside of the array printed in the snapshot
TODO