cache control: don't apply default max age until after resolver runs #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also gives resolvers the ability to differentiate between a `maxAge` that was explicitly set but happens to equal the default `maxAge` and one that was not explicitly set. Fixes #5488. Helpful for apollo/federation#870.
glasser
force-pushed
the
glasser/cache-default-dynamic-restrict
branch
from
38a6221
to
f1c1732
Compare
abernix
approved these changes
Jul 16, 2021
|
Fix released in 3.0.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also gives resolvers the ability to differentiate between a
maxAgethat was explicitly set but happens to equal the defaultmaxAgeand one that was not explicitly set.Fixes #5488. Helpful for apollographql/federation#870.